commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Barrie Treloar (JIRA)" <>
Subject [jira] [Commented] (LANG-378) Add new ToStyle to support MultiLine with Indent
Date Wed, 25 May 2011 07:43:47 GMT


Barrie Treloar commented on LANG-378:

The class as implemented is *NOT ThreadSafe*.

I forgot that ToStyles where meant to be singletons and there is state kept in this class
(i.e. the singleton) for use when indenting/outdenting.
Obviously this isn't thread safe if two threads attempt to use this ToStyle on different objects
at the same time.

> Add new ToStyle to support MultiLine with Indent
> ------------------------------------------------
>                 Key: LANG-378
>                 URL:
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.builder.*
>    Affects Versions: 2.3
>            Reporter: Barrie Treloar
>            Priority: Minor
>             Fix For: 3.x
>         Attachments: LANG-378-patch.txt,
> Multiline support  places everything on a new line with no indentation to help in readability.
> Attached is a patch (with tests) to support Multiline behaviour with indentation.

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message