commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arne Plöse (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MATH-573) in ArrayFielVector i.e. subtract calls wrong constructor
Date Fri, 13 May 2011 06:48:47 GMT

    [ https://issues.apache.org/jira/browse/MATH-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032847#comment-13032847
] 

Arne Plöse commented on MATH-573:
---------------------------------

I suggest to remove all constructores that not specify whether the data should be copied or
not. If you do so you will find many "wrong" usages ...

An other point why there is the interface FieldVector when the implementing class (ArrayFieldVector)
of FieldVector is leaking out (and in) of ArrayFieldVector on every place - IMHO this is bad
coding style.

> in ArrayFielVector i.e. subtract calls wrong constructor
> --------------------------------------------------------
>
>                 Key: MATH-573
>                 URL: https://issues.apache.org/jira/browse/MATH-573
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Arne Plöse
>            Priority: Minor
>             Fix For: 3.0
>
>
> I.E. subtract calls
> "return new ArrayFieldVector<T>(out)" this constructor clones the array...
> "return new ArrayFieldVector<T>(field, out, false)" would be better (preserving
field as well)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message