commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurizio Cucchiara (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Date Tue, 17 May 2011 17:10:49 GMT

    [ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034888#comment-13034888
] 

Maurizio Cucchiara commented on OGNL-9:
---------------------------------------

Finally I found the culprit: it looks like there is a little difference between the jvm implementations
(5,6).
Particularly, if you set a breakpoint at line 2725 of the [OgnlRuntime Class|http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java?revision=1103138&view=markup],
running the test, you will realize that the 1.5 version behave a just a bit different from
the 1.6 implementation (see the order of the array methods).
OGNL works fine with 1.6 by sheer coincidence, after all if you are looking for a property/getter
for the name "next" which is the best candidate between the method hasNext and the one called
next (I would say next, but I'm afraid it's a matter of taste)

> Upgrade JUnit to version4
> -------------------------
>
>                 Key: OGNL-9
>                 URL: https://issues.apache.org/jira/browse/OGNL-9
>             Project: OGNL (Incubating)
>          Issue Type: Task
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>         Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4,
as a first step just upgrading the dependency and refactoring the Test classes just by dropping
the TestCase inheritance and using the annotation would be enough (methods refactoring dropping
the 'test' prefix can be postponed).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message