Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 11 Apr 2011 04:51:05 +0000 (UTC)
From: "Daniel Savarese (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <534706634.48300.1302497465739.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1187135388.15154.1301239385771.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (NET-393) Should the sendCommandWithID() methods
 be public?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/NET-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018195#comment-13018195 ] 

Daniel Savarese commented on NET-393:
-------------------------------------

sendCommandWithID being public is consistent with the original design intent for base protocol classes.  Why are you not discussing these issues on the development mailing list first?

> Should the sendCommandWithID() methods be public?
> -------------------------------------------------
>
>                 Key: NET-393
>                 URL: https://issues.apache.org/jira/browse/NET-393
>             Project: Commons Net
>          Issue Type: Sub-task
>            Reporter: Sebb
>            Priority: Minor
>
> Should the sendCommandWithID() methods be public?
> These allow the user to override the tag generation, or even send invalid tags.
> I think it would be better to reserve these for internal use.
> If a use case for them is found later, the visibility can be changed back. 
> But reducing visibility breaks binary compatibility - best to start with minimal visibility (and mutabiliy) and relax as necessary later.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira