Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 29 Apr 2011 05:54:03 +0000 (UTC)
From: "Henri Yandell (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <354990779.11125.1304056443126.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1102083875.73608.1303399685738.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LANG-696) Deprecate ClassUtils
 getShortClassName in favor of Class getSimpleName
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026864#comment-13026864 ] 

Henri Yandell commented on LANG-696:
------------------------------------

So you're suggesting we have: 

  public static String getShortName(Object object, String valueIfNull) 
  public static String getShortName(Class<?> cls) 
  public static String getShortName(String className) 
  public static String getSimpleName(Class<?> cls) 
  public static String getSimpleName(Object object, String valueIfNull) 

With the difference between 'Short' and 'Simple' being Map.Entry vs Entry? We also use getShortName in a few places and will have to decide which method we wish to use. 

Given that the maintenance for the method isn't huge; I'm beginning to think we should punt on this for 3.0 and deal with at a later date. We can live with a deprecated getShortName if need be.

> Deprecate ClassUtils getShortClassName in favor of Class getSimpleName
> ----------------------------------------------------------------------
>
>                 Key: LANG-696
>                 URL: https://issues.apache.org/jira/browse/LANG-696
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 2.6
>            Reporter: Gary D. Gregory
>            Assignee: Gary D. Gregory
>             Fix For: 3.0
>
>
> Added two null-safe ClassUtils.getSimpleName() APIs.
> ---------- Forwarded message ----------
> From: Gary Gregory <garydgregory@gmail.com>
> Date: Mon, Apr 11, 2011 at 10:18 AM
> Subject: [Lang] ClassUtils getShortClassName != Class getSimpleName
> To: Commons Developers List <dev@commons.apache.org>
> Hi All:
> Should we deprecate ClassUtils getShortClassName in favor of Class getSimpleName?
> The behavior of getShortClassName is undocumented for arrays in the Javadoc and is different from getSimpleName.
> When I replace the guts of getShortClassName to call getSimpleName, one test fails:
> junit.framework.ComparisonFailure: null expected:<[ToStringStyleTest.]Person[name=John Q. ...> but was:<[]Person[name=John Q. ...>
>     at junit.framework.Assert.assertEquals(Assert.java:81)
>     at junit.framework.Assert.assertEquals(Assert.java:87)
>     at org.apache.commons.lang3.builder.ShortPrefixToStringStyleTest.testPerson(ShortPrefixToStringStyleTest.java:86)
> For now, I've made a note in the Javdoc to consider using getSimpleName.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira