commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregor K (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FILEUPLOAD-189) DiskFileItemFactory use of FileCleaningTracker is documated or coded wrong
Date Thu, 07 Apr 2011 08:06:05 GMT
DiskFileItemFactory use of FileCleaningTracker is documated or coded wrong
--------------------------------------------------------------------------

                 Key: FILEUPLOAD-189
                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-189
             Project: Commons FileUpload
          Issue Type: Bug
            Reporter: Gregor K
            Priority: Minor


Regarding latest SVN revision:

The DiskFileItemFactory documents:
Temporary files are automatically deleted as soon as they are no longer needed. (More precisely,
when the corresponding instance of {@link java.io.File} is garbage collected.)

But the code in DiskFileItemFactory.createItem() is doing:
tracker.track(result.getTempFile(), this);

Which means the file is cleaned when DiskFileItemFactory is garbage collected.

This error is propably introduced in Rev 578253 when the code was moved from DiskFileItem
to DiskFileItemFactory, without changing "this" (which was DiskFileItem) and is not DiskFileItemFactory.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message