commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <>
Subject [jira] [Commented] (LANG-696) Deprecate ClassUtils getShortClassName in favor of Class getSimpleName
Date Thu, 28 Apr 2011 04:49:03 GMT


Henri Yandell commented on LANG-696:

The only issue I see is that inner classes report as only their class name in the new JVM
code and not the surrounding class. So "Entry" instead of "Map.Entry". Our old code produced
"Map.Entry". I see this in 5 test fails, one of which is your ToStringStyle fail.

We need to decide which is 'more' correct. Do we wrap the JVM method and fix this, or do we
change our get(String) method to stop reporting the surrounding class.

> Deprecate ClassUtils getShortClassName in favor of Class getSimpleName
> ----------------------------------------------------------------------
>                 Key: LANG-696
>                 URL:
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 2.6
>            Reporter: Gary D. Gregory
>            Assignee: Gary D. Gregory
>             Fix For: 3.0
> Added two null-safe ClassUtils.getSimpleName() APIs.
> ---------- Forwarded message ----------
> From: Gary Gregory <>
> Date: Mon, Apr 11, 2011 at 10:18 AM
> Subject: [Lang] ClassUtils getShortClassName != Class getSimpleName
> To: Commons Developers List <>
> Hi All:
> Should we deprecate ClassUtils getShortClassName in favor of Class getSimpleName?
> The behavior of getShortClassName is undocumented for arrays in the Javadoc and is different
from getSimpleName.
> When I replace the guts of getShortClassName to call getSimpleName, one test fails:
> junit.framework.ComparisonFailure: null expected:<[ToStringStyleTest.]Person[name=John
Q. ...> but was:<[]Person[name=John Q. ...>
>     at junit.framework.Assert.assertEquals(
>     at junit.framework.Assert.assertEquals(
>     at org.apache.commons.lang3.builder.ShortPrefixToStringStyleTest.testPerson(
> For now, I've made a note in the Javdoc to consider using getSimpleName.

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message