commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISCOVERY-15) implementing a commons-logging wrapper is an overkill
Date Tue, 05 Apr 2011 10:43:06 GMT

    [ https://issues.apache.org/jira/browse/DISCOVERY-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015849#comment-13015849
] 

Simone Tripodi commented on DISCOVERY-15:
-----------------------------------------

Ah, yes, It could be that, for old commons-logging releases, they used the discovery to discover
Log implementations :P
BTW upgrading to latest commons-logging release (already done) the circular dependency is
no more detected, is it fine for you removing the 'log' package from discovery?

Moreover I'd like to remove also the below methods from classes...

{code}
public static void setLog(Log _log) {
    log = _log;
}
{code}

> implementing a commons-logging wrapper is an overkill
> -----------------------------------------------------
>
>                 Key: DISCOVERY-15
>                 URL: https://issues.apache.org/jira/browse/DISCOVERY-15
>             Project: Commons Discovery
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 0.5
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> org.apache.commons.discovery.log is a commons-logging implementation wrapper, moreover
the 90% of classes that use a Log instance, have a static setter method.
> It should be enough just using commons-logging in the 'traditional' way :P

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message