commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bogdan Drozdowski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-402) BufferedReader used for control channel, which does not follow the standard
Date Tue, 12 Apr 2011 17:05:06 GMT

    [ https://issues.apache.org/jira/browse/NET-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018907#comment-13018907
] 

Bogdan Drozdowski commented on NET-402:
---------------------------------------

Daniel, look at bug NET-349, which, by the way, should be closed along with this issue. Although
many operating systems will prevent the user from creating files with CRs or LFs in the name,
this is not forbidden by many filesystems (often the only forbidden character is the binary
zero byte). So even if the server is conforming, a file-listing command result can break parsing
just because the filename had a CR/LF. Similar things could happen anywhere where the client
receives a listing of filesystem names (probably including IMAP, where you can create your
own mailboxes).

So, on one hand, we stop supporting non-conforming servers (which could mean that we're supporting
less servers now), but on the other hand we're fixing a bug that someone has found in a real-life
system.

> BufferedReader used for control channel, which does not follow the standard
> ---------------------------------------------------------------------------
>
>                 Key: NET-402
>                 URL: https://issues.apache.org/jira/browse/NET-402
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> BufferedReader is used for wrapping the control channel, and uses its readLine() for
getting responses from the server.
> The IMAP, NNTP, POP3 and SMTP protocols require CRLF at the end of lines, but Bufferedreader#readLine()
also allows bare CR and LF terminators, which could potentially be included in a server reply.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message