commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (DISCOVERY-17) Enumeration returned by Service.providers has a broken behavior
Date Fri, 08 Apr 2011 16:24:05 GMT

    [ https://issues.apache.org/jira/browse/DISCOVERY-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017511#comment-13017511
] 

Simone Tripodi edited comment on DISCOVERY-17 at 4/8/11 4:22 PM:
-----------------------------------------------------------------

Or, much better:

{code}
return new Enumeration<S>() {

            public boolean hasMoreElements() {
                return services.hasNext();
            }

            public S nextElement() {
                ResourceClass<S> info = services.nextResourceClass();

                if (info == null) {
                    throw new NoSuchElementException();
                }

                try {
                    return spi.newInstance(info.loadClass());
                } catch (Exception e) {
                    return null;
                } catch (UnsatisfiedLinkError ule) {
                    return null;
                } catch (ExceptionInInitializerError eiie) {
                    return null;
                }
            }
        };
{code}

      was (Author: simone.tripodi):
    Or, much better:

{code}
return new Enumeration<S>() {

            public boolean hasMoreElements() {
                return services.hasNext();
            }

            public S nextElement() {
                ResourceClass<S> info = services.nextResourceClass();

                if (info == null) {
                    throw new NoSuchElementException();
                }

                try {
                    return spi.newInstance(info.loadClass());
                } catch (Throwable e) {
                    // TODO log exception
                    return null;
                }
            }
        };
{code}
  
> Enumeration returned by Service.providers has a broken behavior
> ---------------------------------------------------------------
>
>                 Key: DISCOVERY-17
>                 URL: https://issues.apache.org/jira/browse/DISCOVERY-17
>             Project: Commons Discovery
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 0.5
>
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> I find the current Enumeration behavior broken, but please tell me if I'm wrong!!!
> This is the actual current behavior:
> {code}
> return new Enumeration<S>() {
>             private S object = getNextClassInstance();
>             public boolean hasMoreElements() {
>                 return object != null;
>             }
>             public S nextElement() {
>                 if (object == null) {
>                     throw new NoSuchElementException();
>                 }
>                 S obj = object;
>                 object = getNextClassInstance();
>                 return obj;
>             }
>             private S getNextClassInstance() {
>                 while (services.hasNext()) {
>                     ResourceClass<S> info = services.nextResourceClass();
>                     try {
>                         return spi.newInstance(info.loadClass());
>                     } catch (Exception e) {
>                         // ignore
>                     }
>                 }
>                 return null;
>             }
>         };
> {code}
> but shouldn't it be
> {code}
> return new Enumeration<S>() {
>             public boolean hasMoreElements() {
>                 return services.hasNext();
>             }
>             public S nextElement() {
>                 ResourceClass<S> info = services.nextResourceClass();
>                 try {
>                     return spi.newInstance(info.loadClass());
>                 } catch (Throwable e) {
>                     // TODO log exception
>                     return null;
>                 }
>             }
>         };
> {code}
> I think there's no need to comment both codes, please tell me why the first one should
be right :P

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message