commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-688) Proposed code simplifications for BooleanUtils
Date Thu, 07 Apr 2011 05:38:05 GMT

    [ https://issues.apache.org/jira/browse/LANG-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016704#comment-13016704
] 

Henri Yandell commented on LANG-688:
------------------------------------

There seem to three types of change:

1) Removing lots of pointless tenerary operators. 
2) Removing else blocks to match the local code style.
3) Removing ternary operators and relying on autoboxing of boolean to Boolean.

The first two are fine, I don't care on #2 but if you do then go for it. #3 feels a bit weird,
but I think it's fine. 

Gotta wonder why we have BooleanUtils.isTrue(Boolean). Seems like there are a bunch of methods
we can remove in BooleanUtils with the answer of 'use autoboxing'. 


> Proposed code simplifications for BooleanUtils
> ----------------------------------------------
>
>                 Key: LANG-688
>                 URL: https://issues.apache.org/jira/browse/LANG-688
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.0
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LANG-688.patch.txt
>
>
> Patch forthcoming for team consideration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message