commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DBCP-351) setAutoCommit called too many times
Date Sat, 23 Apr 2011 20:50:05 GMT

     [ https://issues.apache.org/jira/browse/DBCP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phil Steitz updated DBCP-351:
-----------------------------

    Fix Version/s:     (was: 1.4.1)
                       (was: 1.3.1)
                   2.0

Changing fix version to 2.0.  I am still not sure how, if at all, we should address this;
but I don't think this can be addressed in a patch release.

> setAutoCommit called too many times
> -----------------------------------
>
>                 Key: DBCP-351
>                 URL: https://issues.apache.org/jira/browse/DBCP-351
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: OD
>             Fix For: 2.0
>
>
> passivateObject in PoolableConnectionFactory sets autoCommit to true, even if defaultAutoCommit
is set to false. This results in two extra db queries for every use of the connection (set
false, do work, set true). This creates a significant amount of overhead, even if the connection
is never even used.
> I propose it be changed to:
> if(conn.getAutoCommit() != _defaultAutoCommit)
> {
>   conn.setAutoCommit(_defaultAutoCommit);
> }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message