Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 22 Mar 2011 17:19:07 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <749482430.4138.1300814347191.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1675978417.13629.1300539989565.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (NET-381) Parsing is inefficient, as it parses
 everything twice
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/NET-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-381:
---------------------

    Component/s: FTP

> Parsing is inefficient, as it parses everything twice
> -----------------------------------------------------
>
>                 Key: NET-381
>                 URL: https://issues.apache.org/jira/browse/NET-381
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>            Reporter: Sebb
>
> The default preParse() method  - FTPFileEntryParserImpl.preParse() - parses every entry, and removes any that do not parse.
> The entries are later parsed again to produce the main output.
> It would be more efficient to weed out null entries once after parsing.
> The preParse() method should be reserved for cases where it is strictly necessary, e.g. VMSVersioningFTPEntryParser and MVSFTPEntryParser which already override the default implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira