Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 22 Mar 2011 00:38:05 +0000 (UTC)
From: "Phil Steitz (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1843935307.2904.1300754285741.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <16441002.43591293546287577.JavaMail.jira@thor>
Subject: [jira] [Commented] (POOL-179) GenericObjectPool.borrowObject()
 incorrectly swallos InterruptedException
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/POOL-179?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130094=
90#comment-13009490 ]=20

Phil Steitz commented on POOL-179:
----------------------------------

The current code in the 2.0 branch contains this same bug.  I will port the=
 fix to the 2.0 code for the time being (we have talked about replacing the=
 core implementation in 2.0).

> GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
> -------------------------------------------------------------------------
>
>                 Key: POOL-179
>                 URL: https://issues.apache.org/jira/browse/POOL-179
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.5.5
>         Environment: mac osx 10.5.8 jdk 1.6.0_22
>            Reporter: Axel Gro=C3=9Fmann
>             Fix For: 1.5.6
>
>         Attachments: FileDiff154-155.jpg
>
>
> I just updated from commpons-pool 1.5.4 to 1.5.5 and suddenly some of my =
tests crash with threads hanging.
> After some inspection is appears that GenericObjectPool.borrowObject() no=
 longer handles InterruptedException correctly. I made a file diff and foun=
d that there has been a modification in that area that contains the bug. Se=
e attached image.
> I have created a patched version absed on 1.5.4 source which works correc=
tly in my use case. The important part is:
> {code:java}
> catch (final InterruptedException e)
> {
>    synchronized (this)
>    {
>       if (latch.getPair() =3D=3D null)
>       {
>          _allocationQueue.remove(latch);
>       }
>       else
>       {
>          _numInternalProcessing--;
>          _numActive++;
>          _allocationQueue.remove(latch);
>          returnObject(latch.getPair().value);
>       }
>    }
>    Thread.currentThread().interrupt();
>    throw e;
> }
> {code}=20

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira