Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 46168 invoked from network); 27 Mar 2011 22:07:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Mar 2011 22:07:43 -0000 Received: (qmail 80994 invoked by uid 500); 27 Mar 2011 22:07:43 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 80937 invoked by uid 500); 27 Mar 2011 22:07:43 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 80929 invoked by uid 99); 27 Mar 2011 22:07:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Mar 2011 22:07:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Mar 2011 22:07:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BCD25571FA for ; Sun, 27 Mar 2011 22:07:05 +0000 (UTC) Date: Sun, 27 Mar 2011 22:07:05 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: <1615228894.15692.1301263625770.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1187135388.15154.1301239385771.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (NET-393) Should the sendCommandWithID() methods be public? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NET-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-393. ---------------------- Resolution: Fixed > Should the sendCommandWithID() methods be public? > ------------------------------------------------- > > Key: NET-393 > URL: https://issues.apache.org/jira/browse/NET-393 > Project: Commons Net > Issue Type: Sub-task > Reporter: Sebb > Priority: Minor > > Should the sendCommandWithID() methods be public? > These allow the user to override the tag generation, or even send invalid tags. > I think it would be better to reserve these for internal use. > If a use case for them is found later, the visibility can be changed back. > But reducing visibility breaks binary compatibility - best to start with minimal visibility (and mutabiliy) and relax as necessary later. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira