commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (NET-381) Parsing is inefficient, as it parses everything twice
Date Tue, 22 Mar 2011 17:19:07 GMT

     [ https://issues.apache.org/jira/browse/NET-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb updated NET-381:
---------------------

    Component/s: FTP

> Parsing is inefficient, as it parses everything twice
> -----------------------------------------------------
>
>                 Key: NET-381
>                 URL: https://issues.apache.org/jira/browse/NET-381
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>            Reporter: Sebb
>
> The default preParse() method  - FTPFileEntryParserImpl.preParse() - parses every entry,
and removes any that do not parse.
> The entries are later parsed again to produce the main output.
> It would be more efficient to weed out null entries once after parsing.
> The preParse() method should be reserved for cases where it is strictly necessary, e.g.
VMSVersioningFTPEntryParser and MVSFTPEntryParser which already override the default implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message