commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COMPRESS-125) BZip2CompressorInputStream throws IOException if underlying stream returns available() == 0
Date Wed, 23 Mar 2011 11:11:05 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb updated COMPRESS-125:
--------------------------

    Description: 
BZip2CompressorInputStream,init() will throw an IOException, if the passed stream returns
0 for available():
{code:title=BZip2CompressorInputStream.java|borderStyle=solid}
    private void init() throws IOException {
        ...
        if (in.available() == 0) {
            throw new IOException("Empty InputStream");
        }
        ...
     }
{code} 

I think this is not correct, because the underlying stream may indeed be able to only return
0 bytes without blocking but may be able to block a little and then return some more bytes.
Note also the change in the API documentation from: "Returns the number of bytes that can
be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".


  was:
BzipCompressorInput,init() will throw an IOException, if the passed stream returns 0 for available():
{code:title=BzipCompressorInput,.java|borderStyle=solid}
    private void init() throws IOException {
        ...
        if (in.available() == 0) {
            throw new IOException("Empty InputStream");
        }
        ...
     }
{code} 

I think this is not correct, because the underlying stream may indeed be able to only return
0 bytes without blocking but may be able to block a little and then return some more bytes.
Note also the change in the API documentation from: "Returns the number of bytes that can
be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".



Fix class name

> BZip2CompressorInputStream throws IOException if underlying stream returns available()
== 0
> -------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-125
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-125
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Compressors
>    Affects Versions: 1.1
>            Reporter: Robert Lichtenberger
>            Priority: Minor
>
> BZip2CompressorInputStream,init() will throw an IOException, if the passed stream returns
0 for available():
> {code:title=BZip2CompressorInputStream.java|borderStyle=solid}
>     private void init() throws IOException {
>         ...
>         if (in.available() == 0) {
>             throw new IOException("Empty InputStream");
>         }
>         ...
>      }
> {code} 
> I think this is not correct, because the underlying stream may indeed be able to only
return 0 bytes without blocking but may be able to block a little and then return some more
bytes.
> Note also the change in the API documentation from: "Returns the number of bytes that
can be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message