commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bogdan Drozdowski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (NET-397) FTPSClient does not handle AUTH or ADAT and only partially handles PBSZ. FTPSCommand should be deprecated
Date Thu, 31 Mar 2011 15:38:05 GMT

     [ https://issues.apache.org/jira/browse/NET-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bogdan Drozdowski updated NET-397:
----------------------------------

    Attachment: ftps-rfc2228.diff

This patch adds the support for 5 missing commands from RFC2228: AUTH, ADAT, MIC, ENC and
CONF. PROT, CCC and PBSZ were already supported. The patch also adds a convenience method
for CCC, so that the overridden sendCommand (which looks for CCC) can probably be removed.

The user still has to provide the data and potentially browse the replies if necessary, but
base64-encoding is done automatically. There also is a method for getting ADAT data from the
response.

FTPSCommand could be removed or a new method, say sendFTPSCommand(), added to FTPSClient.
This patch does not provide sendFTPSCommand() or other overridden versions of sendCommand()
in case FTPSCommand is removed.

Don't know how to fix PBSZ. Setting the buffer size in the Socket is probably not enough?

> FTPSClient does not handle AUTH or ADAT and only partially handles PBSZ. FTPSCommand
should be deprecated 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: NET-397
>                 URL: https://issues.apache.org/jira/browse/NET-397
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: ftps-rfc2228.diff
>
>
> FTPSClient does not provide any code to handle AUTH or ADAT, and does not provide support
for handling a reduced buffer size provided by the server.
> FTPSCommand defines int values for AUTH and ADAT, but if the integer values are used
by client code, the value will be passed to FTPClient, which uses its own array of command
strings, and FTPSCommand.AUTH will translate to "USER" and ADAT => "PASS", similarly for
PBSZ, PROT and CCC.
> These commands all need special handling, so should be dealt with by FTPSClient only.
> FTPSClient can override the sendCommand(int) and sendCommand(int, String) methods in
FTPClient which will help prevent problems.
> Since most of these commands need additional special handling, there should be execNAME()
methods for each.
> FTPSCommand should be deprecated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message