commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (NET-396) POP3.setState() should not be public
Date Tue, 29 Mar 2011 01:49:05 GMT
POP3.setState() should not be public
------------------------------------

                 Key: NET-396
                 URL: https://issues.apache.org/jira/browse/NET-396
             Project: Commons Net
          Issue Type: Bug
          Components: POP3
    Affects Versions: 2.2
            Reporter: Sebb


The POP3 method setState() is public. However, the state should only be settable by library
methods, not by client code, otherwise the state checks won't work correctly.

Changing the visibility would break binary compatibility.

To maintain compatibility there could be a new method (package-private, which would give test
cases access) which is allowed to set the state. Also change the public method to either do
nothing or throw an UnsupportedOperationException.

The getState() method can remain public.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message