commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bogdan Drozdowski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-333) would you provide a class used for imap protocol?
Date Sun, 27 Mar 2011 15:55:05 GMT

    [ https://issues.apache.org/jira/browse/NET-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011811#comment-13011811
] 

Bogdan Drozdowski commented on NET-333:
---------------------------------------

GMail doesn't seem to even support the port 143 (and you probably can't or normally don't
issue a STARTTLS command on an SSL connection). Anyway, I'm glad it's working for you too
now. Just a few more issues:
* if the IMAPReply class won't be final, change private to protected on at least the fields
* getAdditionalReply() still present, don't forget
* subtask 2 (sendCommandWithID): although we provide our own automatic tagging, the user may
for some reason want or need custom tags (like the traditional A000 instead of our AAAA).
* subtask 3 (sendUntaggedCommand): yes, see AuthenticatingIMAPClient.java. At least protected.
But if the user wants to perform manual authentication (with some other method, like GSSAPI
for example), these should be public.
* subtask 1 (enum issue): if you still want an enum after what I've said, I don't mind. You
probably know better what you're doing :)

Nice work with the code, it's cleaner now.

> would you provide a class used for imap protocol?
> -------------------------------------------------
>
>                 Key: NET-333
>                 URL: https://issues.apache.org/jira/browse/NET-333
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: iceviewer
>         Attachments: IMAP.zip, IMAPMail.java
>
>
> would you provide a class used for imap protocol?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message