commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (NET-381) Parsing is inefficient, as it parses everything twice
Date Sat, 19 Mar 2011 13:06:29 GMT
Parsing is inefficient, as it parses everything twice
-----------------------------------------------------

                 Key: NET-381
                 URL: https://issues.apache.org/jira/browse/NET-381
             Project: Commons Net
          Issue Type: Improvement
            Reporter: Sebb


The default preParse() method  - FTPFileEntryParserImpl.preParse() - parses every entry, and
removes any that do not parse.

The entries are later parsed again to produce the main output.

It would be more efficient to weed out null entries once after parsing.

The preParse() method should be reserved for cases where it is strictly necessary, e.g. VMSVersioningFTPEntryParser
and MVSFTPEntryParser which already override the default implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message