commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miroslav Pokorny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MATH-490) Add methods for BigDecimal and BigInteger arithmetic that are not available in the standard offerings
Date Thu, 17 Mar 2011 04:51:29 GMT

    [ https://issues.apache.org/jira/browse/MATH-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007810#comment-13007810
] 

Miroslav Pokorny commented on MATH-490:
---------------------------------------

Looks good/interesting. 

Few suggestions:

- As another user, we love Javadoc :)
- remove the main/test from the GenericXXX classes - not sure why they are there, they must
be left overs.
- GenericInteger.isEven(BigInteger) can be replaced with a simple test if bit 0 of the BigInteger
is clear.
- It seems many methods are unnecessary re-creating BigInteger instances eg: GenericInteger.max/min,
do the compare and return the answer, without copying.
- Please make your classes immutable or clarify in javadoc.
- Please join the method calls with a few parameters instead of putting each param on a single
line. Its really hard to follow as a few statements quickly overflow onto another screen.


> Add methods for BigDecimal and BigInteger arithmetic that are not available in the standard
offerings
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MATH-490
>                 URL: https://issues.apache.org/jira/browse/MATH-490
>             Project: Commons Math
>          Issue Type: Wish
>            Reporter: Andy Turner
>            Priority: Minor
>         Attachments: Generic_1.1.zip
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message