Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sat, 5 Feb 2011 02:57:30 +0000 (UTC)
From: "Phil Steitz (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <922628298.1326.1296874650679.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <433713909.3218.1296585509059.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Commented: (MATH-506) The static field
 ChiSquareTestImpl.distribution serves no purpose
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MATH-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990893#comment-12990893 ] 

Phil Steitz commented on MATH-506:
----------------------------------

Agreed.  Since the fix for MATH-349 this instance field is unnecessary.

> The static field ChiSquareTestImpl.distribution serves no purpose
> -----------------------------------------------------------------
>
>                 Key: MATH-506
>                 URL: https://issues.apache.org/jira/browse/MATH-506
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.1, 3.0
>            Reporter: Sebb
>            Priority: Minor
>
> The static field ChiSquareTestImpl.distribution serves no purpose.
> There is a setter for it, but in every case where the field is used, it is first overwritten with a new value.
> The field and the setter should be removed, and the methods that create a new instance should create a local variable instead.
> For Math 2.1, the field can be removed and the setter deprecated.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira