commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] Created: (MATH-521) Changes in "HarmonicCoefficientsGuesser"
Date Mon, 21 Feb 2011 22:52:39 GMT
Changes in "HarmonicCoefficientsGuesser"
----------------------------------------

                 Key: MATH-521
                 URL: https://issues.apache.org/jira/browse/MATH-521
             Project: Commons Math
          Issue Type: Improvement
            Reporter: Gilles
            Assignee: Gilles
            Priority: Minor
             Fix For: 3.0


(1) The "guess" method throws "OptimizationException" when the algorithm fails to determine
valid values for amplitude and angular frequency.
There are no test showing how such a situation can occur.
Moreover, since this procedure is used to provide an initial guess to an optimizer, it is
better to pick any values for those parameters (e.g. zero) and let the optimizer proceed from
that initial point.

(2) The class javadoc seems very thorough in explaining the algorithm, but is quite unreadable
in the source code, making it fairly useless for checking how the code complies with the comments.
I think that this explanation should go in the user guide (and leave a mostly "plain text"
outline of the algorithm, referring to the guide for details). [Does the format of the user
guide allow such tricky (ASCII "art") constructs?]


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message