commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacopo Cappellato (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (SANDBOX-219) ExtendedBufferedReader does too much
Date Tue, 01 Feb 2011 17:44:29 GMT

     [ https://issues.apache.org/jira/browse/SANDBOX-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacopo Cappellato resolved SANDBOX-219.
---------------------------------------

    Resolution: Fixed

Patch committed in rev. 1065948

> ExtendedBufferedReader does too much
> ------------------------------------
>
>                 Key: SANDBOX-219
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-219
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: CSV
>            Reporter: Henri Yandell
>             Fix For: CSV 1.0
>
>         Attachments: SANDBOX-219.patch
>
>
> There is unnecessary work in ExtendedBufferedReader. 
> It offers:
> skip(long)
> skipUntil(char)
> readUntil(char)
> none are ever called. skip(long) is required to fulfill the superclass, but could be
stubbed out as it's never called.
> The class is also unnecessarily public for CSV's uses.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message