commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] Commented: (MATH-521) Changes in "HarmonicCoefficientsGuesser"
Date Wed, 23 Feb 2011 15:58:38 GMT


Gilles commented on MATH-521:

I've added 2 test cases in revision 1073796.

One covers the "guesser" code when the original algorithm fails. However it is not a very
robust test (nothing is actually tested).

The second is commented out (because it doesn't work). Maybe the initial algorithm should
check earlier that something is wrong with the input data (a single "x" value with different

> Changes in "HarmonicCoefficientsGuesser"
> ----------------------------------------
>                 Key: MATH-521
>                 URL:
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>              Labels: api-change, documentation
>             Fix For: 3.0
>         Attachments: example_LaTeXLet.tar.gz
> (1) The "guess" method throws "OptimizationException" when the algorithm fails to determine
valid values for amplitude and angular frequency.
> There are no test showing how such a situation can occur.
> Moreover, since this procedure is used to provide an initial guess to an optimizer, it
is better to pick any values for those parameters (e.g. zero) and let the optimizer proceed
from that initial point.
> (2) The class javadoc seems very thorough in explaining the algorithm, but is quite unreadable
in the source code, making it fairly useless for checking how the code complies with the comments.
I think that this explanation should go in the user guide (and leave a mostly "plain text"
outline of the algorithm, referring to the guide for details). [Does the format of the user
guide allow such tricky (ASCII "art") constructs?]

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message