commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CODEC-113) org.apache.commons.codec.language.RefinedSoundex.US_ENGLISH_MAPPING should be package protected MALICIOUS_CODE
Date Thu, 27 Jan 2011 23:35:45 GMT

    [ https://issues.apache.org/jira/browse/CODEC-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987833#action_12987833
] 

Sebb commented on CODEC-113:
----------------------------

As far as I can tell there is no need to reference the variable externally, so why not make
it private?

> org.apache.commons.codec.language.RefinedSoundex.US_ENGLISH_MAPPING should be package
protected MALICIOUS_CODE
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CODEC-113
>                 URL: https://issues.apache.org/jira/browse/CODEC-113
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.4
>         Environment: Apache Maven 3.0.2 (r1056850; 2011-01-08 19:58:10-0500)
> Java version: 1.6.0_23, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_23\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows vista", version: "6.0", arch: "amd64", family: "windows"
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 1.5
>
>
> Findbugs says:
> org.apache.commons.codec.language.RefinedSoundex.US_ENGLISH_MAPPING should be package
protected	MALICIOUS_CODE	http://findbugs.sourceforge.net/bugDescriptions.html#MS_PKGPROTECT

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message