commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Semrau (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LANG-663) org.apache.commons.lang3.math.Fraction does not always succeed in multiplyBy and divideBy
Date Mon, 03 Jan 2011 13:48:46 GMT

    [ https://issues.apache.org/jira/browse/LANG-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976735#action_12976735
] 

Christian Semrau commented on LANG-663:
---------------------------------------

Oh, and seeing that method Fraction.addSub (both in Lang and Math) does all it can to ensure
that spurious overflow is prevented (by using a BigInteger for an intermediate value), I wonder
if the overflow of 2 / 3 divided by MIN_VALUE / 3 would be acceptable (in the Math version!),
when it can be prevented too.

> org.apache.commons.lang3.math.Fraction does not always succeed in multiplyBy and divideBy
> -----------------------------------------------------------------------------------------
>
>                 Key: LANG-663
>                 URL: https://issues.apache.org/jira/browse/LANG-663
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.math.*
>    Affects Versions: 3.0
>            Reporter: Christian Semrau
>            Priority: Minor
>             Fix For: 3.0
>
>
> The Fraction.multiplyBy and divideBy methods fail sometimes when the arguments are not
reduced.
> {code:title=FunctionTest.java|borderStyle=solid}
>     public void testMultiply() {
>         // ...
>         f1 = Fraction.getFraction(Integer.MAX_VALUE, Integer.MAX_VALUE);
>         f2 = Fraction.getFraction(42, 1);
>         f = f1.multiplyBy(f2);
>         assertEquals(42, f.getNumerator());
>         assertEquals(1, f.getDenominator());
>     public void testDivide() {
>         // ...
>         f1 = Fraction.getFraction(Integer.MAX_VALUE, Integer.MAX_VALUE);
>         f2 = Fraction.getFraction(42, 1);
>         f = f1.divideBy(f2);
>         assertEquals(1, f.getNumerator());
>         assertEquals(42, f.getDenominator());
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message