commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacopo Cappellato (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SANDBOX-219) ExtendedBufferedReader does too much
Date Mon, 31 Jan 2011 08:56:11 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988694#comment-12988694
] 

Jacopo Cappellato commented on SANDBOX-219:
-------------------------------------------

Is it ok if I commit Henri's patch?


> ExtendedBufferedReader does too much
> ------------------------------------
>
>                 Key: SANDBOX-219
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-219
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: CSV
>            Reporter: Henri Yandell
>             Fix For: CSV 1.0
>
>         Attachments: SANDBOX-219.patch
>
>
> There is unnecessary work in ExtendedBufferedReader. 
> It offers:
> skip(long)
> skipUntil(char)
> readUntil(char)
> none are ever called. skip(long) is required to fulfill the superclass, but could be
stubbed out as it's never called.
> The class is also unnecessarily public for CSV's uses.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message