commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] Commented: (MATH-422) Constructor calls overrideable methods
Date Thu, 06 Jan 2011 14:02:45 GMT


Sebb commented on MATH-422:

The setters don't add any functionality to the class, because the constructor allows all the
values to be set.
Rather than try to re-use the class with a different setting, just create a new instance of
the class.
It has very little data, so won't require much storage.

The getters are potentially useful, as they allow access to the defaults.

I agree - the setters should be removed.

> Constructor calls overrideable methods
> --------------------------------------
>                 Key: MATH-422
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 3.0
> The ctor MicrosphereInterpolator(int microsphereElements, int brightnessExponent) calls
2 public setters that are not final.
> This is unsafe if the class is ever extended.
> Likewise for ComplexFormat(String imaginaryCharacter, NumberFormat realFormat,  NumberFormat
> Are the setters even needed?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message