commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Großmann (JIRA) <j...@apache.org>
Subject [jira] Updated: (POOL-179) GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
Date Tue, 28 Dec 2010 16:16:47 GMT

     [ https://issues.apache.org/jira/browse/POOL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Axel Großmann updated POOL-179:
-------------------------------

    Description: 
I just updated from commpons-pool 1.5.4 to 1.5.5 and suddenly some of my tests crash with
threads hanging.

After some inspection is appears that GenericObjectPool.borrowObject() no longer handles InterruptedException
correctly. I made a file diff and found that there has been a modification in that area that
contains the bug. See attached image.

I have created a patched version absed on 1.5.4 source which works correctly in my use case.
The important part is:
{code:java}
catch (final InterruptedException e)
{
   synchronized (this)
   {
      if (latch.getPair() == null)
      {
         _allocationQueue.remove(latch);
      }
      else
      {
         _numInternalProcessing--;
         _numActive++;
         _allocationQueue.remove(latch);
         returnObject(latch.getPair().value);
      }
   }
   Thread.currentThread().interrupt();
   throw e;
}
{code} 

  was:
I just updated from commpons-pool 1.5.4 to 1.5.5 and suddenly some of my tests crash with
threads hanging.

After some inspection is appears that GenericObjectPool.borrowObject() no longer handles InterruptedException
correctly. I made a file diff and found that there has been a modification in that area that
contains the bug. See attached image.

I have created a patched version absed on 1.5.4 source which works correctly in my use case.
The important part is:
{code:java}
catch (final InterruptedException e)
{
   // TODO hybris start
   synchronized (this)
   {
      if (latch.getPair() == null)
      {
         _allocationQueue.remove(latch);
      }
      else
      {
         _numInternalProcessing--;
         _numActive++;
         _allocationQueue.remove(latch);
         returnObject(latch.getPair().value);
      }
   }
   Thread.currentThread().interrupt();
   throw e;
}
{code} 


> GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
> -------------------------------------------------------------------------
>
>                 Key: POOL-179
>                 URL: https://issues.apache.org/jira/browse/POOL-179
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.5.5
>         Environment: mac osx 10.5.8 jdk 1.6.0_22
>            Reporter: Axel Großmann
>         Attachments: FileDiff154-155.jpg
>
>
> I just updated from commpons-pool 1.5.4 to 1.5.5 and suddenly some of my tests crash
with threads hanging.
> After some inspection is appears that GenericObjectPool.borrowObject() no longer handles
InterruptedException correctly. I made a file diff and found that there has been a modification
in that area that contains the bug. See attached image.
> I have created a patched version absed on 1.5.4 source which works correctly in my use
case. The important part is:
> {code:java}
> catch (final InterruptedException e)
> {
>    synchronized (this)
>    {
>       if (latch.getPair() == null)
>       {
>          _allocationQueue.remove(latch);
>       }
>       else
>       {
>          _numInternalProcessing--;
>          _numActive++;
>          _allocationQueue.remove(latch);
>          returnObject(latch.getPair().value);
>       }
>    }
>    Thread.currentThread().interrupt();
>    throw e;
> }
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message