commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] Commented: (VFS-336) AbstractRandomAccessContent.mode is never used
Date Sat, 04 Dec 2010 20:39:11 GMT

    [ https://issues.apache.org/jira/browse/VFS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966850#action_12966850
] 

Ralph Goers commented on VFS-336:
---------------------------------

I'm not sure I even understand the point of the mode. The RandomAccessContent interface doesn't
have any methods for writing so I don't know what would use it.

> AbstractRandomAccessContent.mode is never used
> ----------------------------------------------
>
>                 Key: VFS-336
>                 URL: https://issues.apache.org/jira/browse/VFS-336
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>
> The mode field in AbstractRandomAccessContent is never used.
> The field is an enum RandomAccessMode with values READ and READWRITE, so one would expect
the mode to be checked by the concrete subclasses.
> The field could be made protected to allow subclasses to use it.
> Or perhaps protected checkRead/checkWrite methods could be added which throw an Exception
if the operation is not permitted

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message