commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (VFS-336) AbstractRandomAccessContent.mode is never used
Date Mon, 06 Dec 2010 16:18:11 GMT

    [ https://issues.apache.org/jira/browse/VFS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967240#action_12967240
] 

Sebb commented on VFS-336:
--------------------------

Huh? "RandomAccessContent extends DataOutput, DataInput."

The subclass LocalFileRandomAccessContent has write methods.

So does SmbFileRandomAccessContent (but that is in the sandbox).

So there could be a use for the mode.

> AbstractRandomAccessContent.mode is never used
> ----------------------------------------------
>
>                 Key: VFS-336
>                 URL: https://issues.apache.org/jira/browse/VFS-336
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>
> The mode field in AbstractRandomAccessContent is never used.
> The field is an enum RandomAccessMode with values READ and READWRITE, so one would expect
the mode to be checked by the concrete subclasses.
> The field could be made protected to allow subclasses to use it.
> Or perhaps protected checkRead/checkWrite methods could be added which throw an Exception
if the operation is not permitted

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message