Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Message-ID: <622431.164851290037033469.JavaMail.jira@thor>
Date: Wed, 17 Nov 2010 18:37:13 -0500 (EST)
From: "Andrew Starodub (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Subject: [jira] Updated: (EMAIL-101) Specified Content-ID is not used when
 embedding a File object in an HtmlEmail
In-Reply-To: <12485747.164431290035833330.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Starodub updated EMAIL-101:
----------------------------------

    Attachment: HtmlEmailTest.patch

Attaching a patch that includes a regression test for making sure the returned CID is the same as the user-specified CID.

> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
>                 Key: EMAIL-101
>                 URL: https://issues.apache.org/jira/browse/EMAIL-101
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.0, 1.1, 1.2
>            Reporter: Andrew Starodub
>             Fix For: 1.3
>
>         Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method. 
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time. 
> I believe this is as simple as changing the last line of .embed(File file, String cid) from: 
> return embed(new FileDataSource(file), file.getName());
> To: 
> return embed(new FileDataSource(file), file.getName(), cid);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.