commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Starodub (JIRA)" <j...@apache.org>
Subject [jira] Updated: (EMAIL-101) Specified Content-ID is not used when embedding a File object in an HtmlEmail
Date Wed, 17 Nov 2010 23:37:13 GMT

     [ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Starodub updated EMAIL-101:
----------------------------------

    Attachment: HtmlEmailTest.patch

Attaching a patch that includes a regression test for making sure the returned CID is the
same as the user-specified CID.

> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
>                 Key: EMAIL-101
>                 URL: https://issues.apache.org/jira/browse/EMAIL-101
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.0, 1.1, 1.2
>            Reporter: Andrew Starodub
>             Fix For: 1.3
>
>         Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument
is never used within the method. 
> Consequently, even when the user specifies a Content-ID for the embedded File, a new
randomly generated Content-ID is generated every time. 
> I believe this is as simple as changing the last line of .embed(File file, String cid)
from: 
> return embed(new FileDataSource(file), file.getName());
> To: 
> return embed(new FileDataSource(file), file.getName(), cid);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message