commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Siebert (JIRA)" <>
Subject [jira] Updated: (POOL-175) Add Builders for Configuration classes
Date Fri, 05 Nov 2010 21:10:41 GMT


Steve Siebert updated POOL-175:

    Attachment: pool2_immutable_config_with_builders_v1

Attached is a half-patch toward this issue and also toward immutable issues/suggestions discussed
in the mailing list (ref:  I don't intend
this patch to be applied, as it is not complete, but would like to solicit feedback to this
approach.  It makes the config instances immutable and adds the Builder patterns.

Implementation in the pool/factories is still debated (I'm for keeping a ref while Phil desires
defensive copies ;) ).  Once I receive feedback on this partial, I will implement both with
java 1.5 java.util.concurrent to see which approach would be preferred by the group =).

Continue on this approach =)

[+1] OK
[+-0] whatever
[-1] you suck: why....

Thanks =)


> Add Builders for Configuration classes
> --------------------------------------
>                 Key: POOL-175
>                 URL:
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>         Attachments: pool2_immutable_config_with_builders_v1
> As suggested by Steven in the mailing-list thread:
> "Last suggestion/question is about making inner (public static final) Builder pattern
classes within the concrete Config classes (and possibly defining an abstract <T extends
Abstract*Config> create() method in the Abstract class).
> This would further simplify the programmatic creation of the Config classes."

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message