commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MATH-422) Constructor calls overrideable methods
Date Fri, 01 Oct 2010 12:59:32 GMT

    [ https://issues.apache.org/jira/browse/MATH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916881#action_12916881
] 

Gilles commented on MATH-422:
-----------------------------

I made {{MicrosphereInterpolator}} immutable in revision 1003521.
[Leaving this issue open for the other class.]


> Constructor calls overrideable methods
> --------------------------------------
>
>                 Key: MATH-422
>                 URL: https://issues.apache.org/jira/browse/MATH-422
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>
> The ctor MicrosphereInterpolator(int microsphereElements, int brightnessExponent) calls
2 public setters that are not final.
> This is unsafe if the class is ever extended.
> Likewise for ComplexFormat(String imaginaryCharacter, NumberFormat realFormat,  NumberFormat
imaginaryFormat)
> Are the setters even needed?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message