Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 473 invoked from network); 21 Sep 2010 20:00:58 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Sep 2010 20:00:58 -0000 Received: (qmail 60477 invoked by uid 500); 21 Sep 2010 20:00:57 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 60390 invoked by uid 500); 21 Sep 2010 20:00:57 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 60382 invoked by uid 99); 21 Sep 2010 20:00:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Sep 2010 20:00:57 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Sep 2010 20:00:54 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8LK0WWm022525 for ; Tue, 21 Sep 2010 20:00:33 GMT Message-ID: <18091718.326261285099232753.JavaMail.jira@thor> Date: Tue, 21 Sep 2010 16:00:32 -0400 (EDT) From: "Niall Pemberton (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (IO-215) FileUtils copy methods swallow date modification failures In-Reply-To: <1075025228.1250704275123.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/IO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated IO-215: ------------------------------- Attachment: IO-215-copy-option-v5.patch Attaching IO-215-copy-option-v5.patch - simplified patch (test case) Having done this work, I'm still wondering whether its really required. Did you have an actual need for this - or was it just from looking at the code? If its the latter and no-one else has ever raised this, then its probably overcomplicating the API for something that no-one needs. > FileUtils copy methods swallow date modification failures > --------------------------------------------------------- > > Key: IO-215 > URL: https://issues.apache.org/jira/browse/IO-215 > Project: Commons IO > Issue Type: Bug > Components: Utilities > Reporter: Sebb > Attachments: IO-215-copy-option-v3.patch, IO-215-copy-option-v5.patch > > > FileUtils.doCopyDirectory(..) and .FileUtils.doCopyFile(..) both call the setLastModified() method, but fail to check if it succeeded or not. > Surely if the caller has asked for the date to be preserved, failure to do so should be reported somehow? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.