commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IO-215) FileUtils copy methods swallow date modification failures
Date Thu, 16 Sep 2010 13:16:33 GMT

    [ https://issues.apache.org/jira/browse/IO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910145#action_12910145
] 

Sebb commented on IO-215:
-------------------------

I like the enum option. It's also backward compatible AFAICS.

BTW, the Javadoc in V2 uses 

@param preserveFileDate ...
rather than
@param option ..

in a couple of places.

I also don't like if (xxx()  == false) - I think that should be if (!xxx()).

> FileUtils copy methods swallow date modification failures
> ---------------------------------------------------------
>
>                 Key: IO-215
>                 URL: https://issues.apache.org/jira/browse/IO-215
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>            Reporter: Sebb
>         Attachments: IO-215-copy-option-v2.patch
>
>
> FileUtils.doCopyDirectory(..) and .FileUtils.doCopyFile(..) both call the setLastModified()
method, but fail to check if it succeeded or not.
> Surely if the caller has asked for the date to be preserved, failure to do so should
be reported somehow?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message