commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siegfried Goeschl (JIRA)" <j...@apache.org>
Subject [jira] Commented: (EXEC-39) StringUtils quoting problems
Date Wed, 15 Sep 2010 18:38:33 GMT

    [ https://issues.apache.org/jira/browse/EXEC-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909837#action_12909837
] 

Siegfried Goeschl commented on EXEC-39:
---------------------------------------

+) fixed the isQuoted() issue

+) what are "special Unix characters"?!



> StringUtils quoting problems
> ----------------------------
>
>                 Key: EXEC-39
>                 URL: https://issues.apache.org/jira/browse/EXEC-39
>             Project: Commons Exec
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>            Assignee: Siegfried Goeschl
>             Fix For: 1.1
>
>
> There are various problems in the StringUtils class:
> isQuoted() - does not check that arguments have the same opening and closing quotes.
This may be a rare case, but it's trivial to fix. There are no test cases for the method.
> quoteArgument()
>  - does not work properly on Windows, which only treats double-quote as a quoting character;
it should not fail if a Windows argument contains single-quotes, as they are not special.
> - does not quote special Unix characters either
> stringSubstitution() does not document what the characters can constitute a key.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message