commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (SANSELAN-42) IPTCConstants: final arrays are not immutable
Date Fri, 10 Sep 2010 17:36:38 GMT
IPTCConstants: final arrays are not immutable
---------------------------------------------

                 Key: SANSELAN-42
                 URL: https://issues.apache.org/jira/browse/SANSELAN-42
             Project: Commons Sanselan
          Issue Type: Bug
            Reporter: Sebb


formats.jpeg.iptc.IPTCConstants contains the following public static final arrays:

IPTC_PREFIX
IPTC_TYPES

Array element are not immutable, even if the array itself is, so the entries could potentially
be corrupted accidentally or deliberately.

IPTC_PREFIX does not appear to be used, so could perhaps be deleted. If not, it could be made
private and a getter added.

IPTC_TYPES only appears to be used in IPTCTypeLookup, so could potentially be moved there
and made private.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message