commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] Commented: (IO-249) Enhance closeQuietly to indicate success
Date Fri, 01 Oct 2010 00:01:32 GMT


Sebb commented on IO-249:

Whis is "e" is in closeQuietly(e, Exception primary) ? Is it the Closable?

Perhaps I'm being dim, but I'm not sure what you expect the method to do.

> Enhance closeQuietly to indicate success
> ----------------------------------------
>                 Key: IO-249
>                 URL:
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.0
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>            Priority: Minor
>             Fix For: 2.x
> A convention of some programmers is to emit a log warning when a resource fails to close.
Granted, such a condition is an error, but there's no reasonable recourse to the failure.
Using IOUtils.closeQuietly() is very useful but all information about the success/failure
is hidden. Returning Throwable will give insight into the error for diagnostic purposes. This
change will be compatible with today's usage since the method currently returns void.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message