commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <>
Subject [jira] Updated: (IO-215) FileUtils copy methods swallow date modification failures
Date Tue, 21 Sep 2010 20:00:32 GMT


Niall Pemberton updated IO-215:

    Attachment: IO-215-copy-option-v5.patch

Attaching IO-215-copy-option-v5.patch - simplified patch (test case)

Having done this work, I'm still wondering whether its really required. Did you have an actual
need for this - or was it just from looking at the code? If its the latter and no-one else
has ever raised this, then its probably overcomplicating the API for something that no-one

> FileUtils copy methods swallow date modification failures
> ---------------------------------------------------------
>                 Key: IO-215
>                 URL:
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>            Reporter: Sebb
>         Attachments: IO-215-copy-option-v3.patch, IO-215-copy-option-v5.patch
> FileUtils.doCopyDirectory(..) and .FileUtils.doCopyFile(..) both call the setLastModified()
method, but fail to check if it succeeded or not.
> Surely if the caller has asked for the date to be preserved, failure to do so should
be reported somehow?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message