commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikkel Meyer Andersen (JIRA)" <>
Subject [jira] Commented: (MATH-384) DescriptiveStatistics based on double[]
Date Mon, 20 Sep 2010 05:54:34 GMT


Mikkel Meyer Andersen commented on MATH-384:

Lines 158-163 in the patch:
+    	final int oldNumElements = numElements;
+    	numElements += values.length;
+    	int newSize = 0;
+    	int i = 1;
should possibly be changed to
+    	final int oldNumElements = numElements;
+    	numElements += values.length;
+    	int newSize = internalArray.length;
+    	int i = 1;
to avoid looping if not necessary.

> DescriptiveStatistics based on double[]
> ---------------------------------------
>                 Key: MATH-384
>                 URL:
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Mikkel Meyer Andersen
>            Priority: Minor
>             Fix For: 2.2
>         Attachments: patch-MATH-384-2, ResizableArrayInstantiatedByArray
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> Right now the DescriptiveStatistics is for ResizableDoubleArray, but if the user has
the double[] data she wishes to get DescriptiveStatistics for there is no way of doing this
(besides the inefficient way of creating a ResizableDoubleArray from the double[]).
> It would be possible to use StatUtils, but it does not contain near as much functionality
as DescriptiveStatistics.
> Idea: Create a DescriptiveStatistics for double[] also. I'm not sure which way of implementing
it would be the best, but one way would be to make DescriptiveStatistics abstract with all
but the apply-method implemented as now. The apply-method should be made as abstract which
then has to implemented in the extensions together with a field containing the values. (addValue,
windowSize etc. has to go in the ResizableDoubleArray-extension.) The double[]-extension should
then have a constructor taking double[] as a parameter.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message