commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (VFS-318) ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser with null systemName
Date Mon, 20 Sep 2010 15:46:34 GMT
ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser
with null systemName
------------------------------------------------------------------------------------------------------------------------

                 Key: VFS-318
                 URL: https://issues.apache.org/jira/browse/VFS-318
             Project: Commons VFS
          Issue Type: Improvement
            Reporter: Sebb


ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser(String)
with null systemName if the getSystemName() method fails.

The resulting ParserInitializationException does not identify the cause.

It would be better to throw a more specific error if the system name cannot be found.

Ideally, getSystemName() should throw the error, but that would change the documented behaviour
(null is specifically allowed as a return value).

As it happens, getSystemName() is badly named, so one way forward is to create a new method
getSystemType() which never returns null.

Can then deprecate getSystemName().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message