Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 10057 invoked from network); 30 Aug 2010 19:57:33 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Aug 2010 19:57:33 -0000 Received: (qmail 68707 invoked by uid 500); 30 Aug 2010 19:57:33 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 68624 invoked by uid 500); 30 Aug 2010 19:57:32 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 68616 invoked by uid 99); 30 Aug 2010 19:57:32 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Aug 2010 19:57:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Aug 2010 19:57:15 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o7UJurKL011268 for ; Mon, 30 Aug 2010 19:56:54 GMT Message-ID: <27191319.74021283198213903.JavaMail.jira@thor> Date: Mon, 30 Aug 2010 15:56:53 -0400 (EDT) From: "Jean-Noel Rouvignac (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (COLLECTIONS-362) CollectionUtils.filter() should return a boolean indicating whether the Collection was modified as a result of the call. In-Reply-To: <4784128.33021282923473143.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COLLECTIONS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Noel Rouvignac updated COLLECTIONS-362: -------------------------------------------- Attachment: COLLECTIONS-362.patch Here are the updated class and tests. I think this is an API change, so it won't happen until commons collections 4? > CollectionUtils.filter() should return a boolean indicating whether the Collection was modified as a result of the call. > ------------------------------------------------------------------------------------------------------------------------ > > Key: COLLECTIONS-362 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-362 > Project: Commons Collections > Issue Type: Wish > Components: Collection > Affects Versions: 3.2 > Reporter: Jean-Noel Rouvignac > Priority: Minor > Attachments: COLLECTIONS-362.patch > > > Here is what I mean: > - test 1: > List l = new ArrayList(); > l.add("test"); > assertTrue( CollectionUtils.filter(l, FalsePredicate.getInstance()) ); > assertTrue(l.isEmpty()); > - test 2: > List l = new ArrayList(); > l.add("test"); > assertFalse( CollectionUtils.filter(l, TruePredicate.getInstance()) ); > assertEquals(1, l.size()); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.