Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 45791 invoked from network); 22 Aug 2010 13:17:59 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Aug 2010 13:17:59 -0000 Received: (qmail 57333 invoked by uid 500); 22 Aug 2010 13:17:59 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 56996 invoked by uid 500); 22 Aug 2010 13:17:57 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 56987 invoked by uid 99); 22 Aug 2010 13:17:56 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Aug 2010 13:17:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Aug 2010 13:17:38 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o7MDHGva026612 for ; Sun, 22 Aug 2010 13:17:17 GMT Message-ID: <22474481.494351282483036895.JavaMail.jira@thor> Date: Sun, 22 Aug 2010 09:17:16 -0400 (EDT) From: "Phil Steitz (JIRA)" To: issues@commons.apache.org Subject: [jira] Resolved: (MATH-392) calculateYVariance in OLS/GLSMultipleLinearRegression uses residuals not Y vars In-Reply-To: <454077.501251279737831149.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MATH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved MATH-392. ------------------------------ Resolution: Fixed Fixed in 987897. I added calcluate/estimateErrorVariance methods to return what was previously incorrectly reported as "Y variance." Thanks for the patch! > calculateYVariance in OLS/GLSMultipleLinearRegression uses residuals not Y vars > ------------------------------------------------------------------------------- > > Key: MATH-392 > URL: https://issues.apache.org/jira/browse/MATH-392 > Project: Commons Math > Issue Type: Bug > Affects Versions: 2.1 > Reporter: Mark Devaney > Priority: Minor > Fix For: 2.2 > > Attachments: patch > > > Implementation of OLS/GLSMultipleLinearRegression is: > @Override > 173 protected double calculateYVariance() { > 174 RealVector residuals = calculateResiduals(); > 175 return residuals.dotProduct(residuals) / > 176 (X.getRowDimension() - X.getColumnDimension()); > 177 } > This gives variance of residuals not variance of the dependent (Y) variable as the documentation suggests. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.