Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 60829 invoked from network); 11 Aug 2010 11:10:46 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Aug 2010 11:10:46 -0000 Received: (qmail 377 invoked by uid 500); 11 Aug 2010 11:10:45 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 99895 invoked by uid 500); 11 Aug 2010 11:10:42 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 99887 invoked by uid 99); 11 Aug 2010 11:10:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Aug 2010 11:10:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Aug 2010 11:10:39 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o7BBAHcL008955 for ; Wed, 11 Aug 2010 11:10:17 GMT Message-ID: <21642885.273461281525017537.JavaMail.jira@thor> Date: Wed, 11 Aug 2010 07:10:17 -0400 (EDT) From: "Gilles (JIRA)" To: issues@commons.apache.org Subject: [jira] Updated: (MATH-404) Confusing interface for "LevenbergMarquardtOptimizer" In-Reply-To: <28263662.231611281354256674.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MATH-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated MATH-404: ------------------------ Fix Version/s: 3.0 (was: 2.2) I'm trying to define a more general "ConvergenceChecker" interface. This is an incompatible change. > Confusing interface for "LevenbergMarquardtOptimizer" > ----------------------------------------------------- > > Key: MATH-404 > URL: https://issues.apache.org/jira/browse/MATH-404 > Project: Commons Math > Issue Type: Bug > Affects Versions: 2.1 > Reporter: Gilles > Assignee: Gilles > Fix For: 3.0 > > > {{LevenbergMarquardtOptimizer}} inherits from {{AbstractLeastSquaresOptimizer}} which in turn implements {{DifferentiableMultivariateVectorialOptimizer}}. That interface mandates methods for setting and getting a {{VectorialConvergenceChecker}}. > In v2.1, however, that checker is never used! The convergence check is performed using parameters specific to the Levenberg-Marquardt algorithm. Such circumvention of the superclass interface is confusing and leads to totally unexpected behaviour (such as changing the values of the thresholds of the {{VectorialConvergenceChecker}} being ineffective). > In the development version, the default constructor of {{LevenbergMarquardtOptimizer}} sets the the {{VectorialConvergenceChecker}} field to "null" and when such is the case, the behaviour is as in v2.1. Although it is documented, this is still confusing since it is impossible to use {{LevenbergMarquardtOptimizer}} through its {{DifferentiableMultivariateVectorialOptimizer}} interface: When using the {{VectorialConvergenceChecker}}, one does not know what parameters to use in order to reproduce the results obtained with the LM-specific convergence check (i.e. how to reproduce the result from v2.1). > Unless I'm missing something, I think that there should be an LM-specific implementation of {{VectorialConvergenceChecker}} that, when given the usual relative and absolute thresholds, can perform a check that will give the same result as the currently specific check (when the "checker" field is "null"). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.