Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 54087 invoked from network); 23 Aug 2010 21:29:41 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Aug 2010 21:29:41 -0000 Received: (qmail 7397 invoked by uid 500); 23 Aug 2010 21:29:40 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 6957 invoked by uid 500); 23 Aug 2010 21:29:40 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 6901 invoked by uid 99); 23 Aug 2010 21:29:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Aug 2010 21:29:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Aug 2010 21:29:39 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o7NLTJlf012207 for ; Mon, 23 Aug 2010 21:29:19 GMT Message-ID: <13188692.518031282598959047.JavaMail.jira@thor> Date: Mon, 23 Aug 2010 17:29:19 -0400 (EDT) From: "Leo Izen (JIRA)" To: issues@commons.apache.org Subject: [jira] Issue Comment Edited: (COMPRESS-91) jar recognition is curently impossible. In-Reply-To: <279707968.1258577799817.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COMPRESS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901592#action_12901592 ] Leo Izen edited comment on COMPRESS-91 at 8/23/10 5:28 PM: ----------------------------------------------------------- I tried this myself. If JarArchiveInputStream is before ZipArchiveInputStream, then when you open a file that is .zip but not .jar, it will return JarArchiveInputStream. There is no way to tell the difference between a jar and a zip file without looking at the file extension. was (Author: thebombzen): I tried this myself. If JarArchiveInputStream is before ZipArchiveInputStream, then when you open a file that is .zip but not .jar, it will return JarArchiveInputStream. There is no way to tell the difference between a jar and a zip file without looking at file extension. > jar recognition is curently impossible. > --------------------------------------- > > Key: COMPRESS-91 > URL: https://issues.apache.org/jira/browse/COMPRESS-91 > Project: Commons Compress > Issue Type: Bug > Affects Versions: 1.0 > Environment: W2K and unbuntu JRE1.4 to 1.6. > Reporter: Torelli > Priority: Minor > > In ArchiveStreamFactory.createArchiveInputStream(final InputStream in), > JarArchiveInputStream must be before ZipArchiveInputStream > and a positive jar identification have to be confirmed by the first file entry (META-INF/MANIFEST.MF). > Regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.