Return-Path: Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: (qmail 7740 invoked from network); 5 Aug 2010 11:18:44 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 Aug 2010 11:18:44 -0000 Received: (qmail 34317 invoked by uid 500); 5 Aug 2010 11:18:44 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 33422 invoked by uid 500); 5 Aug 2010 11:18:41 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 33414 invoked by uid 99); 5 Aug 2010 11:18:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Aug 2010 11:18:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Aug 2010 11:18:38 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o75BIGwI027368 for ; Thu, 5 Aug 2010 11:18:16 GMT Message-ID: <10692161.178361281007096337.JavaMail.jira@thor> Date: Thu, 5 Aug 2010 07:18:16 -0400 (EDT) From: "Phil Steitz (JIRA)" To: issues@commons.apache.org Subject: [jira] Commented: (MATH-401) Policy concerning "null" In-Reply-To: <25865696.178031281003796650.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MATH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895647#action_12895647 ] Phil Steitz commented on MATH-401: ---------------------------------- Yes, these messages exist now and I would like to keep them. > Policy concerning "null" > ------------------------ > > Key: MATH-401 > URL: https://issues.apache.org/jira/browse/MATH-401 > Project: Commons Math > Issue Type: Improvement > Reporter: Gilles > Assignee: Gilles > Priority: Trivial > Fix For: 3.0 > > > Following the discussion on the "dev" ML, it appears that it would be fine to not check for {{null}} references within CM. The JVM will do it anyway so that it is redundant and not necessary most of the time (i.e. when usage is valid). When it happens, the problem is obvious enough that the standard {{NullPointerException}} fully describes it, without the need for additional specific and localized detailed messages. > Hence we could remove all explicit checks for {{null}}. Or when early failure is preferred, make the check and throw {{NullPointerException}} (without a message argument). > Since failed checks are currently reported with an {{IllegalArgumentException}}, the change is not backward-compatible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.